Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on adding diagnostic output. #331

Merged
merged 26 commits into from
Mar 18, 2021

Conversation

dabail10
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    This is only a documentation update.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    I will make sure this builds in readthedocs via the Travis check.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This is a starting point for the tips on adding diagnostics. I am open to suggestions. This addresses issue Document how to add diagnostic output #317.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't address what happens when a desired variable is buried within layers of subroutines and not easily accessible via a use statement.

@dabail10 does this capture the challenges you faced when adding the isotopes? Conservation was a different issue but still required some additional output, right?


- If the variable is just a scalar, then follow the example of "aice". Copy the write statement for Qa to
a place in the output list where it is most appropriate. The format "900" is appropriate for most scalars.
Edit the copied statement to be the variable you want. The following example adds snow-melt (melts).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is would add what n is, e.g.

The following example adds snow melt (melts) for each of the n points.

(no hyphen needed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a bit more here. Hopefully this is helpful.

- If the variable is already defined within the code, then add it to a "use" statement in the subroutine
``hbrine_diags`` or ``bgc_diags`` or ``zsal_diags``. The similar procedure for state variables is used here.

- Note that the BGC needs to be activited and the particular tracer turned on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spell activated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@dabail10
Copy link
Contributor Author

Right! I also need to add an example when a variable needs to be derived from other variables.

@eclare108213
Copy link
Contributor

This issue has popped back up in the forum, so maybe we should raise its priority...

@eclare108213 eclare108213 linked an issue Nov 10, 2020 that may be closed by this pull request
@dabail10
Copy link
Contributor Author

I've incorporated Elizabeth's changes here and the readthedocs is building fine. I've also added a fix to the documentation as found by @JFLemieux73.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay. We can continue to improve it as new functionality is added, or as users make specific requests. E.g. conservation diagnostics are not addressed.

@dabail10 dabail10 removed the request for review from duvivier March 18, 2021 17:02
@dabail10
Copy link
Contributor Author

I will wait for @JFLemieux73 to have a look. The conservation diagnostics are on my list.

@JFLemieux73
Copy link
Contributor

Thanks Dave for the correction in the section Shortwave radiation: CCSM3. It's ok.

@dabail10 dabail10 merged commit f298152 into CICE-Consortium:master Mar 18, 2021
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
* Initialize revp stresses to previous time step

* Add machine files for brooks

* Modify the documentation about stress initialization in revised evp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to add diagnostic output
3 participants