Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readthedocs requirements #345

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Update readthedocs requirements #345

merged 1 commit into from
Dec 18, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Dec 18, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update readthedocs requirements for bibtex
  • Developer(s):
    apcraig, dabail10
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    No tests carried out, this fixes an issue in the sphinx doc generation
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This was actually discovered and fixed by dabail10 on a separate branch. But this needed to be added to the release branch for the documentation to build. Something changed in a recent update of sphinx (maybe a week ago), so our documentation broke at that time and this is the fix. Thanks @dabail10.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mysteries never end

@dabail10
Copy link
Contributor

As some point we will have to deal with the changes need for 2.0.0 bibtex-sphinx code. This at least works for now.

@apcraig apcraig merged commit 171adc2 into master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants