Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify error tolerance for rare mushy thermo failure #352

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

eclare108213
Copy link
Contributor

  • Short (1 sentence) summary of your PR:
    This is a bugfix for a very infrequent failure in the mushy layer thermodynamics. The mushy temperature change iteration is currently set to a tolerance of ferrmax which is the same as the final energy conservation tolerance. Every so often, when the temperature change iteration error is very close to ferrmax, the total energy conservation will fail because of round-off level errors in the thickness routine.
  • Developer(s):
    @njeffery @eclare108213 @dabail10
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Should not affect any of our tests -- this is expected to be BFB.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit unless the results lie outside of the original error tolerance, which would trigger an abort.
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This problem turned up in MPAS-seaice and was addressed there by lowering the error tolerance in ice_therm_mushy.F90 to 0.9*ferrmax, which will likely not be BFB. Instead, we are loosening the final error tolerance comparison for this rare case, which will not affect any of our tests because they do not hit this problem (they would abort if they did). This modification will allow the code to run without aborting in this special case. See Bug in temperature_change_mushy #233.

@apcraig
Copy link
Contributor

apcraig commented Mar 17, 2021

The icepack test suite is bit-for-bit with this PR. Will test this in CICE next.

https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#8d68802687d01cf7224a2803be88394c8c3e5ced

@apcraig
Copy link
Contributor

apcraig commented Mar 17, 2021

@apcraig apcraig merged commit ee7cf8e into CICE-Consortium:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in temperature_change_mushy
3 participants