Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of CompyMcNodeFace to Icepack machine files #353

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Addition of CompyMcNodeFace to Icepack machine files #353

merged 4 commits into from
Mar 17, 2021

Conversation

proteanplanet
Copy link
Contributor

@proteanplanet proteanplanet commented Mar 16, 2021

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Addition of DOE E3SM machine CompyMcNodeFace to standard machines for which Icepack works.
  • Developer(s):
    @proteanplanet on behalf of E3SM
  • Suggest PR reviewers from list in the column to the right.
    Must be reviewers with access to Compy and who are part of E3SM: @eclare108213 @njeffery
  • Please copy the PR test results link or provide a summary of testing completed below.
    Icepack successfully creates a case, builds, runs and can be submitted to the queue using icepack.setup -m compy ...
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This PR is needed as part of the transition of E3SM to use Icepack. Note that all CICE Consortium forcing data has been copied to Compy from Cori at NERSC, and resides at /compyfs/inputdata/cice-consortium and will be maintained by @proteanplanet with rsync from NERSC. I should have rebased the forked master before starting, but in this instance it was up to date and doesn't matter.

doc: change URL of a reference to avoid '%' character (#339)
Update proteanplanet fork of Icepack master to latest version of Icepack
Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have access to compy and will test independently when I have a chance. We can merge before that though.

@apcraig
Copy link
Contributor

apcraig commented Mar 17, 2021

@apcraig apcraig merged commit e8df0ad into CICE-Consortium:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants