Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to Icepack 1.3.3 #419

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Dec 7, 2022

PR checklist

  • Short (1 sentence) summary of your PR:
    Update version to Icepack 1.3.3
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    tested cheyenne intel test suite, all pass and bit-for-bit.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Update version via icepack.setup --setvers 1.3.3
Update interface documentation via icepack.setup --docintfc
Remove trailing blanks in source code via sed script

Update interface documentation
Remove trailing blanks in source code
Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that all the whitespace and/or tabs get introduced. Looks good though.

@apcraig
Copy link
Contributor Author

apcraig commented Dec 7, 2022

Tested on cheyenne intel, all pass and bit-for-bit.

213 measured results of 213 total results
213 of 213 tests PASSED
0 of 213 tests PENDING
0 of 213 tests MISSING data
0 of 213 tests FAILED

Regarding extra spaces and tabs. I think some of this happens from editors. I use emacs and recent changes do auto-indent which I manually unset in a .config file. Also, sometimes when folks play around with continuation lines, you can sometimes end up with extra spaces at the end of a line. It's not a big deal and I'll periodically do a clean. I have a sed script now so it takes like 2 seconds to clean up.

@apcraig apcraig merged commit 8f96707 into CICE-Consortium:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants