Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs errors, update documentation #432

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 15, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Fix documentation, new errors trapped by readthedocs
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    no testing done
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

There seems to have been a problem with unicode character representing a minus sign. Fixing that seems to fix the pdf generation.

@apcraig
Copy link
Contributor Author

apcraig commented Mar 15, 2023

I will merge this once GHActions checks are done and see if it fixes the documentation and doc badge. I tested the fix in readthedocs, but will have to see whether it really is the fix.

@apcraig apcraig mentioned this pull request Mar 15, 2023
16 tasks
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, must have been some serious sleuthing to find these differences!

@apcraig
Copy link
Contributor Author

apcraig commented Mar 15, 2023

The readthedocs log files helped find the problem. But yes, not easy to find.

@apcraig apcraig merged commit 1eae173 into CICE-Consortium:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants