Re-add Picard Nonconvergence Diagnostics #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new picard nonconvergence messages.
Merge branch 'picardnonconv' of https://github.com/e3sm-project/icepack into picardnonconvdiags See https://github.com/e3sm-Project/icepack/tree/picardnonconv This commit got lost in E3SM-Project, bringing it back into Icepack.
eclare108213
approved these changes
Oct 5, 2023
apcraig
changed the title
dabail10
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Re-add Picard Nonconvgence Diagnostics
Developer(s):
dabail10
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Test results are bit-for-bit. Tested on Icepack and CICE on cheyenne, full test suite, 3 compilers.
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#fd0549efc3307c95e4f0174df2e9773fbb2814df
https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#2a6741c1ec958858e330b327a4a335fa511f405a
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Merge branch 'picardnonconv' of https://github.com/e3sm-project/icepack into picardnonconvdiags
See https://github.com/e3sm-Project/icepack/tree/picardnonconv
This commit got lost in E3SM-Project, bringing it back into Icepack.