Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _old options for tfrz_option #468

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Oct 12, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Remove _old options for tfrz_option
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Full Icepack test suite run on cheyenne, all tests pass. Several tests changes answer (bgc, alt03, alt04, thermo1) as expected. Also ran test suite with these modifications within CICE, all tests pass, some results change answer. https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#2a6741c1ec958858e330b327a4a335fa511f405a
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit, except certain test cases include bgc, alt03, alt04, thermo1
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig apcraig merged commit f6989f1 into CICE-Consortium:main Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants