TC track forecast missing time period handling #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing timeperiods
peanutfun
requested changes
Aug 24, 2023
emanuel-schmid
deleted the
feature/tc_forecast_missing-timeperiod-multimessage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TC track forecast continue reading messages from a multimessage bufr file in case a track is missing the field timeperiod
For example: the forecast of ECMWF contains a storm that is not trackable: https://charts.ecmwf.int/products/cyclone?base_time=202308220000&product=tc_strike_probability&unique_id=07L_EMILY_2023
This is represented in the bufr file by not having a timeperiod defined. In the case of a multimessage bufr file, the rest of the messages should still be read even if one track needs to be discarded. This MR fixes that behaviour and tests it with the above example. The behaviour is now the same for one multimessage bufr file and several bufr files.
PR Author Checklist
develop)PR Reviewer Checklist