Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ctx sources deprecation #517

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Feature/ctx sources deprecation #517

merged 5 commits into from
Jul 20, 2022

Conversation

emanuel-schmid
Copy link
Collaborator

Changes proposed in this PR:

  • Replace contextily.sources with contextily.providers, as suggested in the deprecation warning of contextily 1.1
  • use contextily.providers rather than hard coded urls as default arguments for plotting methods

This PR fixes issue #319

Pull Request Checklist

  • Correct target branch selected (if unsure, select develop)
  • Source branch up-to-date with target branch
  • Docs updated
  • Tests updated
  • Tests passing
  • No new linter issues

@emanuel-schmid
Merge branch 'develop' into feature/ctx-sources-deprecation
bb9cd53 
# Conflicts:
#	climada/engine/impact.py
@frqqyy
Copy link
Collaborator

frqqyy commented Jul 16, 2022 •
edited
Loading

This PR solves the issue #465 effectively. Thank you!

@emanuel-schmid emanuel-schmid merged commit 373ecae into develop Jul 20, 2022
@emanuel-schmid emanuel-schmid deleted the feature/ctx-sources-deprecation branch July 20, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frqqyy frqqyy Awaiting requested review from frqqyy

Assignees
No one assigned
Labels
dependencies warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuel-schmid @frqqyy