Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util.plot.get_transformation: special treatment for DEF_CRS #520

Merged
merged 2 commits into from
Jul 25, 2022
Merged

util.plot.get_transformation: special treatment for DEF_CRS #520

merged 2 commits into from
Jul 25, 2022

Conversation

emanuel-schmid
Copy link
Collaborator

Changes proposed in this PR:

  • Minor change in util.plot.get_transformation: special case for climada.constants.DEF_CRS, EPSG:4326 (WSG 84), use PlateCarree for plotting without issuing a warning

This PR fixes issue #486

Pull Request Checklist

  • Correct target branch selected (if unsure, select develop)
  • Source branch up-to-date with target branch
    - [ ] Docs updated
    - [ ] Tests updated
  • Tests passing
  • No new linter issues

peanutfun
peanutfun approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This resolves my issue ☺️

@emanuel-schmid emanuel-schmid merged commit 293d377 into develop Jul 25, 2022
@emanuel-schmid emanuel-schmid deleted the feature/avoid_crs_warnings branch July 25, 2022 07:58
@emanuel-schmid emanuel-schmid mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peanutfun peanutfun peanutfun approved these changes

Assignees
No one assigned
Labels
warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuel-schmid @peanutfun