Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper function: toggle_extent_bounds #543

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

tovogt
Copy link
Collaborator

@tovogt tovogt commented Oct 5, 2022

Changes proposed in this PR:

PR Author Checklist

PR Reviewer Checklist

@tovogt tovogt requested a review from chahank October 5, 2022 08:53
@chahank
Copy link
Member

chahank commented Oct 7, 2022

Why not, very useful.

Just before we close this here, is it known why CLIMADA uses both conventions? Is there a good reason for it or does legacy explains all of it?

@tovogt
Copy link
Collaborator Author

tovogt commented Oct 9, 2022

No, it's not about legacy. It's just that both conventions are used, one is usually called "extent" and the other is called "bounds". For example, in rasterio the "bounds" convention is more common (e.g. https://rasterio.readthedocs.io/en/latest/api/rasterio.transform.html#rasterio.transform.from_bounds), and in matplotlib the "extent" convention is more common (e.g. https://matplotlib.org/stable/tutorials/intermediate/imshow_extent.html?highlight=extent).

@chahank
Copy link
Member

chahank commented Oct 10, 2022

Yes, this is what I meant :D The fact that CLIMADA does use both conventions instead of just one is for me the legacy.

@emanuel-schmid emanuel-schmid merged commit 845d5b8 into develop Oct 10, 2022
@emanuel-schmid emanuel-schmid deleted the feature/toggle_extent_bounds branch October 10, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants