-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/init measures base #564
Conversation
Co-authored-by: Chahan M. Kropf <[email protected]>
Co-authored-by: Chahan M. Kropf <[email protected]>
Co-authored-by: Chahan M. Kropf <[email protected]>
Co-authored-by: Chahan M. Kropf <[email protected]>
Thanks for the review! All of your suggestions were good and I just merged them. Good point about the |
Great! Thanks. I think I did not catch all the instance where defaults where not let to the init. Maybe in |
I went through everything, it's fine 👍 |
Then it is good for me! |
Changes proposed in this PR:
Measure
class.PR Author Checklist
develop
)PR Reviewer Checklist