Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util.coordinates.get_admin1_geometries: pd.concat in lieu of gdf.append #587

Merged
merged 2 commits into from
Nov 23, 2022
Merged

util.coordinates.get_admin1_geometries: pd.concat in lieu of gdf.append #587

merged 2 commits into from
Nov 23, 2022

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Nov 18, 2022 •
edited by peanutfun
Loading

Changes proposed in this PR:

  • replace deprecated geopandas.GeoDataFrame.append by pandas.concat in get_admin1_geometries

This PR is analogous to #443

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun self-assigned this Nov 23, 2022
@peanutfun
Copy link
Member

Great, thanks for taking care of this!

@peanutfun peanutfun merged commit 868660e into develop Nov 23, 2022
@emanuel-schmid emanuel-schmid deleted the feature/omit_append_future_warning branch November 23, 2022 21:38
@chahank chahank mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peanutfun peanutfun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuel-schmid @peanutfun