Improve functionality of Hazard.from_raster_xarray #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Repeat single-valued coordinates/attributes for the number of events loaded. * Transform dates into ordinals instead of directly loading ordinals.
* Optionally repeat 'frequency' data. * Set default 'fraction' to None, complying with the new __init__. * Add tests for repeating single-valued data. * Modify tests to check for correct fraction initialization.
Update docstrings and tests.
Move Notes below Parameters.
|
@emanuel-schmid I finished working on this, it's ready for review! 🙌 |
Co-authored-by: Lukas Riedel <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
None, which complies with the new__init__signatureThe changes of this PR help me implement my GloFAS river flood model, see CLIMADA-project/climada_petals#60
PR Author Checklist
develop)❌ 3 new LOW issues
PR Reviewer Checklist