Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog #626

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Add changelog #626

merged 4 commits into from
Jan 27, 2023

Conversation

peanutfun
Copy link
Member

@peanutfun peanutfun commented Jan 20, 2023

Changes proposed in this PR:

  • Add a CHANGELOG.md file to keep track of changes
  • Update PR description template and Git development guide accordingly

I think keeping a changelog makes much more sense than having the Upcoming Release overview that is detached from the code base.

PR Author Checklist

PR Reviewer Checklist

Add link to PR
@emanuel-schmid
Copy link
Collaborator

Good idea! 👍
Just one question - why don't we merge it into develop first?

@peanutfun
Copy link
Member Author

why don't we merge it into develop first?

Because the PR templates on GitHub are always taken from main. If we merge into develop, I fear that nobody will notice we have a changelog, as there will be no new item in the Checklist until we merge develop into main 🤓

My proposal would be to merge this into main, then merge main into develop in a new PR.

@emanuel-schmid emanuel-schmid merged commit fe2502b into main Jan 27, 2023
@emanuel-schmid
Copy link
Collaborator

I see, yes, makes sense. Let's try 😁

@emanuel-schmid emanuel-schmid deleted the add-changelog branch February 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants