Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: yearsets frequency curve calculations fail #703

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

ChrisFairless
Copy link
Collaborator

@ChrisFairless ChrisFairless commented Apr 19, 2023

Changes proposed in this PR:

  • Small bugfix to yearsets. An Impact.at_event object needs to be a numpy array, or it can't be reindexed in the Impact.calc_freq_curve calculation. The yearsets class creates these as lists so frequency curve calcuations currently fail. From the documentation they are clearly supposed to be arrays when they are calculated in the compute_imp_per_year method. The fix is one line.

PR Author Checklist

PR Reviewer Checklist

@chahank
Copy link
Member

chahank commented Apr 20, 2023

Great! Can you please just adjust the docstring to return a np.ndarray?

@ChrisFairless
Copy link
Collaborator Author

Done 👍

@chahank chahank merged commit c4c6dff into develop Apr 20, 2023
@chahank chahank deleted the bugfix/yearsets branch April 20, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants