Bugfix: yearsets frequency curve calculations fail #703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
yearsets
. AnImpact.at_event
object needs to be a numpy array, or it can't be reindexed in theImpact.calc_freq_curve
calculation. Theyearsets
class creates these as lists so frequency curve calcuations currently fail. From the documentation they are clearly supposed to be arrays when they are calculated in thecompute_imp_per_year
method. The fix is one line.PR Author Checklist
develop
)PR Reviewer Checklist