-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCTracks: Option to read additional variables from IBTrACS (e.g. "nature"/stormtype) #728
Conversation
This is great! Looks good, reads well, and everything works. Only one remark: the additional variables include a few numeric fields ( |
These variables are not reported variables, but are provided by IBTrACS as a courtesy to users, e.g. The documentation of |
Thanks for clarifying! Then I think this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
A big THANK YOU @tovogt for writing code and creating this PR, this is highly appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reviews, @ChrisFairless, @bguillod, @peanutfun ! From my side, this is ready to be merged. |
Great, thanks a lot. I'll merge then! |
Changes proposed in this PR:
additional_variables
to theTCTracks.from_ibtracs_netcdf
function that allows users to have additional IBTrACS data fields be included in theTCTracks
object.This PR fixes #674 and replaces #646
PR Author Checklist
develop
)PR Reviewer Checklist