-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove content tables and update tutorial files #872
Conversation
Some additional remarks:
|
Thanks for the cleanup!
@viggowat @chahank Ideas on this? Should we fix this within this PR?
I think it is also redundant with the ToC in the sidebar, and it really does not bring anything else, so I would remove it also. |
I agree, I would remove the links for sure, and probably the entire section. |
@luseverin : do you think you have the information to finish this PR? |
Almost everything yes. Following Sam's and your suggestions I will remove all occurences of "How is this tutorial structured" subsections. Then the only thing I am missing is what to do with this ParseError in |
Excellent! As for the parsing error, I have not had the problem. But, if you find quickly a fix, sure include it. Otherwise, I would open a separate issue. Maybe @spjuhel can say whether he also has the same error? |
Ok so I have removed the remaining "how is this tutorial structured" parts, and fixed the ParseError (following https://tex.stackexchange.com/questions/661333/big-fails-with-invalid-delimiter-type-ordgroup-in-vscode-ipynb-md-cell). I just changed the As far as I'm concerned, we can merge and close this PR. |
Excellent, thanks! From my point of the view, this can be merged. If you find time, I think on climada petals the only tutorial that is not following the convention is https://climada-petals.readthedocs.io/en/stable/tutorial/climada_exposures_openstreetmap.html (the sections are not properly assigned and thus the table of content is empty). You may then also close #862 . |
Ah yes, I did not think of checking the tutorial on petals. So I removed the content table from the |
Thanks! Can you make a PR on climada petals and we continue the discussion there? Then it is a bit clearer, and you may merge this PR here. |
This PR removes content tables from the CLIMADA tutorials and makes various fixes (typos and readability improvements).
Changes proposed in this PR:
This PR fixes #862
PR Author Checklist
develop
)PR Reviewer Checklist