Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

euler user guide update #880

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented May 7, 2024

Changes proposed in this PR:

  • update the Euler user guide to the newest version (the only version that runs with current develop branch)

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the base branch from main to develop May 7, 2024 14:59
@chahank
Copy link
Member

chahank commented May 10, 2024

Looks clear to me. @manniepmkam Did this solve your issues?

@manniepmkam
Copy link
Collaborator

Yes, it works fine for me now. And this version only works with the develop branch but not the main branch. Shall we also indicate that in the guide?

@chahank
Copy link
Member

chahank commented May 10, 2024

Thanks for the feedback. There is no need to add a message about the develop branch I think. This will be merged into the develop branch only, so I think it will be clear.

@emanuel-schmid
Copy link
Collaborator Author

Thanks for the review!

@emanuel-schmid emanuel-schmid merged commit fb6bdf9 into develop May 13, 2024
12 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/euler_guide_update branch May 13, 2024 06:28
gdeskos pushed a commit to gdeskos/climada_python that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants