-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wisc url relocation #944
base: develop
Are you sure you want to change the base?
wisc url relocation #944
Conversation
Ah, nice! That URL had been dead for a while if I recall, but I never had time - and didn't really consider it my task - to go looking for the new location. Take heed that the cds is being decomissioned on 2024-09-26, so it's probably worth waiting with this PR until the beta goes live. I just saw that the individual datasets have gotten a doi, maybe you can use https://doi.org/10.24381/cds.ce973f02 for the synthetic events? I suppose they'll update their DOI resolution URL once the new system goes live... |
in order to avoid circular imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd make the module more useful if the docstring points to the DOIs of the datasets; the ECMWF Confluence page is descriptive of the data, but doesn't actually point to it...
@@ -60,10 +60,10 @@ | |||
|
|||
class StormEurope(Hazard): | |||
"""A hazard set containing european winter storm events. Historic storm | |||
events can be downloaded at http://wisc.climate.copernicus.eu/ and read | |||
events can be downloaded at https://cds.climate.copernicus.eu/ and read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace this with this DOI https://doi.org/10.24381/cds.9b4ea013 althought I must admit that I haven't tested those NetCDFs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I would explicitly mention the synthetic data at https://doi.org/10.24381/cds.ce973f02
Changes proposed in this PR:
This PR fixes #610
PR Author Checklist
develop
)PR Reviewer Checklist