Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IBTrACS to version 4.1 #976

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ChrisFairless
Copy link
Collaborator

@ChrisFairless ChrisFairless commented Nov 12, 2024

Changes proposed in this PR:

This year IBTrACS updated from version 4.0 to 4.1 and on May 28th the last v4.0 dataset was posted to their site.

That means anyone using CLIMADA is using IBTrACS data that hasn't been updated since then, even if they're regularly redownloading the file.

This PR points everything to the location of the new download and updates the tests because some of the tested values have changed.

Changes in v4.1:

  • There's a new provider, KMA, the South Korean agency, with associated columns. I haven't updated CLIMADA for that: this would require someone to find out their wind averaging period and add it to tc_tracks.py
  • It looks like a lot of values have been changed but I haven't looked into what and how much. Many appear to be due to a change in rounding somewhere in the data creation (lat, lon, pressure, wind). Since IBTrACS only gather and summarise data from other bodies, there shouldn't be big changes. Either way, NOAA consider this an improvement on previous versions of the data and we don't have a choice about using it. I had to update some of the tests because of this
  • The TRACK_TYPE column now includes 'PROVISIONAL' as a possible value, which labels provisional US data (A-Deck). These are updated to 'Best Tracks' (B-Deck) by HURDAT after each season ends. It's information only, pointing out something that IBTrACS did already. Nothing in CLIMADA Core uses this column

The (rewritten) tests for the unit all pass.

Note:

  • Users who have previously downloaded the v4.0 data will be left with it on their machine and might not be aware. It's ~25 MB so not tiny but not huge.

PR Author Checklist

PR Reviewer Checklist

@peanutfun
Copy link
Member

Thanks a lot for this PR, @ChrisFairless! 🙌 I am currently on parental leave and will not be able to review until January. Maybe somebody else would be willing? @spjuhel @NicolasColombi

@spjuhel
Copy link
Collaborator

spjuhel commented Nov 12, 2024

Happy to give this a look next week!

@spjuhel spjuhel self-requested a review November 12, 2024 16:45
@NicolasColombi
Copy link
Collaborator

Happy to have a look as well!

Copy link
Collaborator

@spjuhel spjuhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks in order for me.

👍 for replacing the hard-coded filenames!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants