Fix internal header include paths. #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra leading "CLI/" part of include directives prevents the inclusion of CLI.hpp from a relative directory without an extra -I or /I compiler directive, and makes it harder to make CLI11 part of a larger codebase. This is a regression of CLIUtils#475.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4556 +10
Branches 0 971 +971
==========================================
+ Hits 4546 4556 +10 ☔ View full report in Codecov by Sentry. |
|
Is there any way to add this to tests / checks to avoid future regressions? |
henryiii
approved these changes
Feb 26, 2024
|
I think a simple enough test would be, for a specific target:
This makes assumptions about the source tree hierarchy, so I’m afraid it’s not a perfect solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra leading
"CLI/"part of include directives prevents the inclusion ofCLI.hppfrom a relative directory without an extra-Ior/Icompiler directive, and makes it harder to make CLI11 part of a larger codebase.This is a regression of #475.