Skip to content

Commit

Permalink
add opt out logging counts
Browse files Browse the repository at this point in the history
  • Loading branch information
laurenkrugen-navapbc committed Aug 9, 2024
1 parent 742cf94 commit 7ebb377
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
10 changes: 10 additions & 0 deletions bcda/suppression/suppression.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ func (importer OptOutImporter) validate(metadata *optout.OptOutFilenameMetadata)
}

func (importer OptOutImporter) ImportSuppressionData(metadata *optout.OptOutFilenameMetadata) error {
optOutCount := 0
optInCount := 0
err := importer.importSuppressionMetadata(metadata, func(fileID uint, b []byte) error {
suppression, err := optout.ParseRecord(metadata, b)

Expand All @@ -133,13 +135,21 @@ func (importer OptOutImporter) ImportSuppressionData(metadata *optout.OptOutFile
importer.Logger.Error(err)
return err
}
switch suppression.PrefIndicator {
case "Y":
optInCount++
case "N":
optOutCount++
return nil
}
return nil
})

if err != nil {
importer.updateImportStatus(metadata, optout.ImportFail)
return err
}
importer.Logger.WithFields(logrus.Fields{"created_opt_outs_count": optOutCount, "created_opt_ins_count": optInCount}).Info()
importer.updateImportStatus(metadata, optout.ImportComplete)
return nil
}
Expand Down
18 changes: 18 additions & 0 deletions bcda/suppression/suppression_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import (
"time"

"github.com/DATA-DOG/go-sqlmock"
"github.com/sirupsen/logrus"
log "github.com/sirupsen/logrus"
"github.com/sirupsen/logrus/hooks/test"

"github.com/CMSgov/bcda-app/bcda/constants"
"github.com/CMSgov/bcda-app/bcda/database"
Expand Down Expand Up @@ -74,6 +76,7 @@ func TestSuppressionTestSuite(t *testing.T) {
func (s *SuppressionTestSuite) TestImportSuppression() {
assert := assert.New(s.T())

hook := test.NewLocal(logrus.StandardLogger())
// 181120 file
fileTime, _ := time.Parse(time.RFC3339, "2018-11-20T10:00:00Z")
metadata := &optout.OptOutFilenameMetadata{
Expand Down Expand Up @@ -134,6 +137,21 @@ func (s *SuppressionTestSuite) TestImportSuppression() {
assert.Equal("N", suppressions[200].PrefIndicator)
assert.Equal("1000098787", suppressions[249].MBI)
assert.Equal("", suppressions[249].PrefIndicator)

var optOut, optIn bool
entry := hook.LastEntry()
if _, ok := entry.Data["created_opt_outs_count"]; ok {
optOut = true
assert.Equal(entry.Data["created_opt_outs_count"], 86)
}
if _, ok := entry.Data["created_opt_ins_count"]; ok {
optIn = true
assert.Equal(entry.Data["created_opt_ins_count"], 71)
}

assert.True(optOut)
assert.True(optIn)

}

func (s *SuppressionTestSuite) TestImportSuppression_MissingData() {
Expand Down

0 comments on commit 7ebb377

Please sign in to comment.