fix linting issues

bcda/cclf/utils/cclfUtils.go

@@ -18,6 +18,7 @@ import (
 	"github.com/CMSgov/bcda-app/conf"
 	"github.com/CMSgov/bcda-app/log"
 	"github.com/CMSgov/bcda-app/optout"
+	"github.com/ccoveille/go-safecast"
 )
 
 // ImportCCLFPackage will copy the appropriate synthetic CCLF files, rename them,
@@ -129,11 +130,17 @@ func ImportCCLFPackage(acoSize, environment string, fileType models.CCLFFileType
 
 	_ = zipWriter.Close()
 
+	hours, err:= safecast.ToUint(utils.GetEnvInt("FILE_ARCHIVE_THRESHOLD_HR", 72))
+
+	if err != nil {
+		return err
+	}
+
 	file_processor := &cclf.LocalFileProcessor{
 		Handler: optout.LocalFileHandler{
 			Logger:                 log.API,
 			PendingDeletionDir:     conf.GetEnv("PENDING_DELETION_DIR"),
-			FileArchiveThresholdHr: uint(utils.GetEnvInt("FILE_ARCHIVE_THRESHOLD_HR", 72)),
+			FileArchiveThresholdHr: hours,
 		},
 	}
 

bcda/models/postgres/alr.go

@@ -11,6 +11,7 @@ import (
 	"github.com/CMSgov/bcda-app/bcda/models"
 	"github.com/CMSgov/bcda-app/bcda/utils"
 	"github.com/CMSgov/bcda-app/log"
+	"github.com/ccoveille/go-safecast"
 	"github.com/jackc/pgx"
 	"github.com/jackc/pgx/pgtype"
 	"github.com/jackc/pgx/stdlib"
@@ -221,7 +222,14 @@ func (r *AlrRepository) GetAlr(ctx context.Context, metakey int64, MBIs []string
 			return nil, err
 		}
 		alr.KeyValue = keyValue
-		alr.MetaKey = uint(metakey)
+
+		key, err:= safecast.ToUint(metakey)
+
+		if err != nil {
+			return nil, err
+		}
+
+		alr.MetaKey = key
 		alrs = append(alrs, &alr)
 	}
 

bcda/responseutils/v2/writer.go

@@ -12,6 +12,7 @@ import (
 	"github.com/CMSgov/bcda-app/bcda/models"
 	"github.com/CMSgov/bcda-app/conf"
 	"github.com/CMSgov/bcda-app/log"
+	"github.com/ccoveille/go-safecast"
 
 	"github.com/google/fhir/go/fhirversion"
 	"github.com/google/fhir/go/jsonformat"
@@ -68,9 +69,15 @@ func CreateJobsBundle(jobs []*models.Job, host string) *fhirmodelCR.Bundle {
 		entries = append(entries, entry)
 	}
 
+	jobLength, err := safecast.ToUint32(len(jobs))
+
+	if err != nil {
+		log.API.Errorln(err)
+	}
+
 	return &fhirmodelCR.Bundle{
 		Type:  &fhirmodelCR.Bundle_TypeCode{Value: fhircodes.BundleTypeCode_SEARCHSET},
-		Total: &fhirdatatypes.UnsignedInt{Value: uint32(len(jobs))},
+		Total: &fhirdatatypes.UnsignedInt{Value: jobLength},
 		Entry: entries,
 	}
 }

bcda/responseutils/writer.go

@@ -13,6 +13,7 @@ import (
 	"github.com/CMSgov/bcda-app/conf"
 	"github.com/CMSgov/bcda-app/log"
 	logAPI "github.com/CMSgov/bcda-app/log"
+	"github.com/ccoveille/go-safecast"
 
 	"github.com/google/fhir/go/fhirversion"
 	"github.com/google/fhir/go/jsonformat"
@@ -64,9 +65,15 @@ func CreateJobsBundle(jobs []*models.Job, host string) *fhirmodels.Bundle {
 		entries = append(entries, entry)
 	}
 
+	jobLength, err := safecast.ToUint32(len(jobs))
+
+	if err != nil {
+		log.API.Errorln(err)
+	}
+
 	return &fhirmodels.Bundle{
 		Type:  &fhircodes.BundleTypeCode{Value: fhircodes.BundleTypeCode_SEARCHSET},
-		Total: &fhirdatatypes.UnsignedInt{Value: uint32(len(jobs))},
+		Total: &fhirdatatypes.UnsignedInt{Value: jobLength},
 		Entry: entries,
 	}
 }

bcda/service/alr.go

@@ -4,12 +4,18 @@ import (
 	"context"
 
 	"github.com/CMSgov/bcda-app/bcda/models"
+	"github.com/CMSgov/bcda-app/log"
+	"github.com/ccoveille/go-safecast"
 )
 
 // GetAlrJobs Get the MBIs and put them into jobs
 func (s *service) GetAlrJobs(ctx context.Context, alrMBI *models.AlrMBIs) []*models.JobAlrEnqueueArgs {
 
-	partition := int(s.alrMBIsPerJob)
+	partition, err := safecast.ToInt(s.alrMBIsPerJob)
+
+	if err != nil {
+		log.API.Errorln(err)
+	}
 
 	loop := len(alrMBI.MBIS) / partition
 

bcda/service/service.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/ccoveille/go-safecast"
 	"github.com/pborman/uuid"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
@@ -293,8 +294,12 @@ func (s *service) createQueueJobs(ctx context.Context, conditions RequestConditi
 						}
 						if resource, ok := GetDataType(rt); ok {
 							if resource.SupportsDataType(dataType) {
+								jobId, err := safecast.ToInt(conditions.JobID)
+								if err != nil {
+									log.API.Errorln(err)
+								}
 								enqueueArgs := models.JobEnqueueArgs{
-									ID:              int(conditions.JobID),
+									ID:              jobId,
 									ACOID:           conditions.ACOID.String(),
 									CMSID:           conditions.CMSID,
 									BeneficiaryIDs:  jobIDs,

bcdaworker/queueing/enqueue.go

@@ -6,6 +6,7 @@ import (
 	"github.com/CMSgov/bcda-app/bcda/database"
 	"github.com/CMSgov/bcda-app/bcda/models"
 	"github.com/bgentry/que-go"
+	"github.com/ccoveille/go-safecast"
 )
 
 const (
@@ -32,10 +33,16 @@ func (q queEnqueuer) AddJob(job models.JobEnqueueArgs, priority int) error {
 		return err
 	}
 
+	p, e := safecast.ToInt16(priority)
+
+	if e != nil {
+		return e
+	}
+
 	j := &que.Job{
 		Type:     QUE_PROCESS_JOB,
 		Args:     args,
-		Priority: int16(priority),
+		Priority: int16(p),
 	}
 
 	return q.Enqueue(j)
@@ -48,10 +55,16 @@ func (q queEnqueuer) AddAlrJob(job models.JobAlrEnqueueArgs, priority int) error
 		return err
 	}
 
+	p, e := safecast.ToInt16(priority)
+
+	if e != nil {
+		return e
+	}
+
 	j := &que.Job{
 		Type:     ALR_JOB,
 		Args:     args,
-		Priority: int16(priority),
+		Priority: int16(p),
 	}
 
 	return q.Enqueue(j)

bcdaworker/queueing/manager/que.go

@@ -17,6 +17,7 @@ import (
 	"github.com/CMSgov/bcda-app/conf"
 	"github.com/CMSgov/bcda-app/log"
 	"github.com/bgentry/que-go"
+	"github.com/ccoveille/go-safecast"
 	"github.com/jackc/pgx"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
@@ -118,6 +119,11 @@ func (q *queue) processJob(queJob *que.Job) error {
 	ctx = log.NewStructuredLoggerEntry(log.Worker, ctx)
 	ctx, _ = log.SetCtxLogger(ctx, "job_id", jobArgs.ID)
 	ctx, logger := log.SetCtxLogger(ctx, "transaction_id", jobArgs.TransactionID)
+	id, e := safecast.ToUint(jobArgs.ID)
+
+	if e != nil {
+		return e
+	}
 
 	exportJob, err := q.worker.ValidateJob(ctx, queJob.ID, jobArgs)
 	if goerrors.Is(err, worker.ErrParentJobCancelled) {
@@ -146,10 +152,11 @@ func (q *queue) processJob(queJob *que.Job) error {
 		logger.Warnf("No job found for ID: %d acoID: %s. Will retry.", jobArgs.ID, jobArgs.ACOID)
 		return errors.Wrap(repository.ErrJobNotFound, "could not retrieve job from database")
 	} else if goerrors.Is(err, worker.ErrQueJobProcessed) {
-		logger.Warnf("Queue job (que_jobs.id) %d already processed for job.id %d. Checking completion status and removing queuejob from que.", queJob.ID, jobArgs.ID)
-		_, err := worker.CheckJobCompleteAndCleanup(ctx, q.repository, uint(jobArgs.ID))
+		logger.Warnf("Queue job (que_jobs.id) %d already processed for job.id %d. Checking completion status and removing queuejob from que.", queJob.ID, id)
+
+		_, err := worker.CheckJobCompleteAndCleanup(ctx, q.repository, id)
 		if err != nil {
-			return errors.Wrap(err, fmt.Sprintf("Error checking job completion & cleanup for job id %d", jobArgs.ID))
+			return errors.Wrap(err, fmt.Sprintf("Error checking job completion & cleanup for job id %d", id))
 		}
 		return nil
 	} else if err != nil {
@@ -159,7 +166,7 @@ func (q *queue) processJob(queJob *que.Job) error {
 	}
 
 	// start a goroutine that will periodically check the status of the parent job
-	go checkIfCancelled(ctx, q.repository, cancel, uint(jobArgs.ID), 15)
+	go checkIfCancelled(ctx, q.repository, cancel, id, 15)
 
 	if err := q.worker.ProcessJob(ctx, queJob.ID, *exportJob, jobArgs); err != nil {
 		err := errors.Wrap(err, "failed to process job")

bcdaworker/worker/worker.go

@@ -24,6 +24,7 @@ import (
 	"github.com/CMSgov/bcda-app/bcdaworker/repository/postgres"
 	"github.com/CMSgov/bcda-app/conf"
 	"github.com/CMSgov/bcda-app/log"
+	"github.com/ccoveille/go-safecast"
 	"github.com/sirupsen/logrus"
 
 	fhircodes "github.com/google/fhir/go/proto/google/fhir/proto/stu3/codes_go_proto"
@@ -48,7 +49,11 @@ func (w *worker) ValidateJob(ctx context.Context, queJobID int64, jobArgs models
 	if len(jobArgs.BBBasePath) == 0 {
 		return nil, ErrNoBasePathSet
 	}
-	exportJob, err := w.r.GetJobByID(ctx, uint(jobArgs.ID))
+	id, err := safecast.ToUint(jobArgs.ID)
+	if err != nil {
+		return nil, err
+	}
+	exportJob, err := w.r.GetJobByID(ctx, id)
 	if goerrors.Is(err, repository.ErrJobNotFound) {
 		return nil, ErrParentJobNotFound
 	} else if err != nil {
@@ -63,7 +68,7 @@ func (w *worker) ValidateJob(ctx context.Context, queJobID int64, jobArgs models
 		return nil, ErrParentJobFailed
 	}
 
-	_, err = w.r.GetJobKey(ctx, uint(jobArgs.ID), queJobID)
+	_, err = w.r.GetJobKey(ctx, id, queJobID)
 	if goerrors.Is(err, repository.ErrJobKeyNotFound) {
 		// No job key exists, which means this queue job needs to be processed.
 		return exportJob, nil
@@ -237,7 +242,11 @@ func CloseOrLogError(logger logrus.FieldLogger, f *os.File) {
 func writeBBDataToFile(ctx context.Context, r repository.Repository, bb client.APIClient,
 	cmsID string, queJobID int64, jobArgs models.JobEnqueueArgs, tmpDir string) (jobKeys []models.JobKey, err error) {
 
-	jobKeys = append(jobKeys, models.JobKey{JobID: uint(jobArgs.ID), QueJobID: &queJobID, FileName: models.BlankFileName, ResourceType: jobArgs.ResourceType})
+	id, err := safecast.ToUint(jobArgs.ID)
+	if err != nil {
+		return nil, err
+	}
+	jobKeys = append(jobKeys, models.JobKey{JobID: id, QueJobID: &queJobID, FileName: models.BlankFileName, ResourceType: jobArgs.ResourceType})
 
 	logger := log.GetCtxLogger(ctx)
 	close := metrics.NewChild(ctx, "writeBBDataToFile")
@@ -370,7 +379,7 @@ func writeBBDataToFile(ctx context.Context, r repository.Repository, bb client.A
 	}
 
 	if errorCount > 0 {
-		jobKeys = append(jobKeys, models.JobKey{JobID: uint(jobArgs.ID), QueJobID: &queJobID, FileName: fileUUID + "-error.ndjson", ResourceType: jobArgs.ResourceType})
+		jobKeys = append(jobKeys, models.JobKey{JobID: id, QueJobID: &queJobID, FileName: fileUUID + "-error.ndjson", ResourceType: jobArgs.ResourceType})
 	}
 	return jobKeys, nil
 }