Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-6109: Remove jobId/clientId headers for non-bulk requests #812

Merged
merged 8 commits into from
Dec 5, 2022

Conversation

ian-sawyer
Copy link
Contributor

Fixes BCDA-6109

Proposed Changes

  • Split addRequestHeaders function into multiple functions pertaining to non-bulk/bulk requests

Change Details

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications
  • no PHI/PII is affected by this change

Acceptance Validation

  • Tests pass

Feedback Requested

  • Verify code looks correct

@codecov-commenter
Copy link

Codecov Report

Merging #812 (45edd2d) into master (dd356ec) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   74.89%   74.87%   -0.02%     
==========================================
  Files          89       89              
  Lines       10279    10285       +6     
==========================================
+ Hits         7698     7701       +3     
- Misses       1977     1979       +2     
- Partials      604      605       +1     
Impacted Files Coverage Δ
bcda/client/bluebutton.go 86.47% <100.00%> (+0.26%) ⬆️
bcda/models/fhir/alr/v2/group.go 87.79% <0.00%> (-1.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd356ec...45edd2d. Read the comment docs.

@ian-sawyer ian-sawyer merged commit c3428e3 into master Dec 5, 2022
@ian-sawyer ian-sawyer deleted the isawyer/BCDA-6109 branch December 5, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants