Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-6627 Update base docker image used for test container #822

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

magile32
Copy link
Contributor

@magile32 magile32 commented Jan 19, 2023

Fixes BCDA-6627

Proposed Changes

Change Details

  • Switch to an Alpine docker image from a Debian base (to be consistent with the rest of BCDA go containers)
  • Execute an update on existing apks on base image
  • Package dependencies added to Dockerfile to support build and test execution

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications
  • no PHI/PII is affected by this change

Acceptance Validation

Successful build and execution of test container on lower environments. Also verify that Snyk findings reported has been reduced.

Feedback Requested

@magile32 magile32 marked this pull request as ready for review January 19, 2023 23:46
@codecov-commenter
Copy link

Codecov Report

Merging #822 (296def5) into master (7448038) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   74.72%   74.81%   +0.08%     
==========================================
  Files          89       89              
  Lines       10300    10300              
==========================================
+ Hits         7697     7706       +9     
+ Misses       1991     1985       -6     
+ Partials      612      609       -3     
Impacted Files Coverage Δ
bcda/models/fhir/alr/v2/group.go 84.30% <0.00%> (+1.74%) ⬆️
bcda/models/fhir/alr/v1/group.go 88.00% <0.00%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7448038...296def5. Read the comment docs.

Copy link
Contributor

@ian-sawyer ian-sawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magile32 magile32 merged commit cddea5f into master Jan 20, 2023
@magile32 magile32 deleted the mly/BCDA-6627 branch January 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants