Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-7135: Worker.go test cov #870

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

laurenkrugen-navapbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-7135

🛠 Changes

Added tests to improve code coverage; #869 had 70% coverage on new code.

ℹ️ Context for reviewers

Additional testing may require refactoring, since much of the uncovered lines are i/o or os operations.

✅ Acceptance Validation

tests pass.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@laurenkrugen-navapbc laurenkrugen-navapbc merged commit 1ce1320 into master Sep 29, 2023
1 check passed
@laurenkrugen-navapbc laurenkrugen-navapbc deleted the lauren/bcda-7135-worker-testcov branch September 29, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants