-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCDA-7786: Create Job Keys for ndjson files #912
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 79.77% 79.80% +0.03%
==========================================
Files 98 98
Lines 10882 10889 +7
==========================================
+ Hits 8681 8690 +9
+ Misses 1653 1651 -2
Partials 548 548
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved; talked about future enhancement to OperationOutcomes for what's written in.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-7786
🛠 Changes
processJob
: moved code to create job keys and update job status into its own function for testingprocessJob
: moved file size check intowriteBBDataToFile
processJob
: creating keys for each Job Key that is returnedwriteBBDataToFile
: changed return values to be a list of JobKeys and an errorwriteBBDataToFile
: returning "*-error.ndjson" job key if it is created (was not being returned and did not have job keys previously)ℹ️ Context for reviewers
error.ndjson files not having job keys written to the database and middleware checks for job keys failing to serve HTTP. These changes will return the ndjson file and pass the middleware check, if the file exists.
✅ Acceptance Validation
Current tests pass, some tests modified, new test added. Lots of intertwined dependencies with this one; was difficult to test.
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.