BCDA-8104 (2/2): Add lambda entrypoint for CCLF import #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyeah
changed the title
alex-dzeda
reviewed
Jun 6, 2024
| func loadBfdS3Params() (string, error) { | ||
| env := conf.GetEnv("ENV") | ||
|
|
||
| bcdaSession, err := bcdaaws.NewSession("", os.Getenv("LOCAL_STACK_ENDPOINT")) |
There was a problem hiding this comment.
comment from the other PR applies here, too, I think this NewSession function may be the spot to consolidate the explanation?
alex-dzeda
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8104
🛠 Changes
ℹ️ Context for reviewers
This PR allows us to run the CCLF import functionality as a lambda. This should look very similar to the Opt Out Import entrypoint, with some minor changes to run the CCLF import instead of Opt Out import.
In particular...
Note that this PR builds on top of #947. I will wait to merge this until 947 is merged.
✅ Acceptance Validation