BCDA-8351: Exclude MD TCoC requests from suppression #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenkrugen-navapbc
requested review from
kyeah,
carlpartridge,
bhagatparwinder and
austincanada
## 🎫 Ticket https://jira.cms.gov/browse/BCDA-8350 ## 🛠 Changes - Adds database documentation in the repo using https://github.com/k1LoW/tbls - Adds github workflow to automatically update PRs that touch the migrations folders ## ℹ️ Context As part of BCDA-8350, I was interested in an easier way to keep the documentation up to date. Although ERDs can be generated manually by tooling like pgAdmin, it would be preferable for devs to have the diagrams generated automatically in a central location. We can still pull the main ERDs into confluence, but instead of making them ourselves we can download them directly from the PR after merging. ## 🧪 Validation See dbdocs in this PR. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Fern <[email protected]>
bcda/web/middleware/validation.go
Outdated
| @@ -30,11 +30,11 @@ type requestkey int | |||
|
|
|||
| const rk requestkey = 0 | |||
|
|
|||
| func NewRequestParametersContext(ctx context.Context, rp RequestParameters) context.Context { | |||
| func NewCtxRequestParams(ctx context.Context, rp RequestParameters) context.Context { | |||
There was a problem hiding this comment.
This function doesnt look like its doing a whole lot for us, do you think its useful? As far as I can tell the two are equivalent:
ctx := NewCtxRequestParams(r.Context(), rp)
ctx := context.WithValue(ctx, 0, rp)
The difference is the requestkey? I didnt understand the comment on it.
There was a problem hiding this comment.
it just checks the context for that particular key; it's not really doing anything for us at this point. It looks like it's used in about 11 places; shall I update those or do we want to keep this PR the current size?
carlpartridge
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8351
🛠 Changes
make unit-testcommand.testdatatofixtures. Old files that were not in use were removed and new files have been addedℹ️ Context
To onboard TCOC, we must exclude beneficiary suppression with their requests.
🧪 Validation
Added integration test will seeded database for suppression data.