Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parwinder/bcda 8306 dependency updates #995

Closed
wants to merge 6 commits into from

Conversation

bhagatparwinder
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8306

🛠 Changes

Updated GO dependencies (docker and protobuf to highlight the important ones)

ℹ️ Context

Multiple CVE vulnerabilities patched

🧪 Validation

Built and ran the project locally.

@bhagatparwinder bhagatparwinder requested a review from a team October 1, 2024 02:02
Copy link
Contributor

@carlpartridge carlpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im seeing a build error on what looks like the docker build of the worker image? Also I am seeing some linting issues locally, probably related to increasing the go version?

@bhagatparwinder
Copy link
Contributor Author

Im seeing a build error on what looks like the docker build of the worker image? Also I am seeing some linting issues locally, probably related to increasing the go version?

Yep. I updated the required dependencies, and all was hunky dory. Decided to tidy up the dependencies > Go updated > Build failed > 🫠. So, I will convert this PR to a draft for now (Either I revert recent commits or make it work with 1.22)

@bhagatparwinder bhagatparwinder marked this pull request as draft October 1, 2024 13:25
@bhagatparwinder bhagatparwinder deleted the parwinder/BCDA-8306-dependency-updates branch October 1, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants