updating dependencies with open security vulnerebilities #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,8 +94,12 @@ func ImportCCLFPackage(acoSize, environment string, fileType models.CCLFFileType | |||
| var archiveName string | |||
|
|
|||
| now := time.Now() | |||
| rand.Seed(now.UnixNano()) | |||
| jitter := rand.Intn(100) // #nosec G404 Need seed for random generator | |||
| jitterBytes := make([]byte, 1) | |||
There was a problem hiding this comment.
Curious on the name here jitterBytes?
There was a problem hiding this comment.
The previous seed was not good enough and had a G404 gosec issue. I updated it to using a random byte. Name change is simply reflecting the type of jitter. I am indifferent, it could stay jitter or jitterByte
The plan is not to generate these automatically but to utilize a static JSON file we manually create. Secondly, I would rely on Git history rather than commented code—just preference. |
carlpartridge
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8306
🛠 Changes
Updated docker engine, retryablehttp
ℹ️ Context
https://jira.cms.gov/browse/BCDA-8245
🧪 Validation
Build the project locally