Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored code in src/settings.js #16

Open
wants to merge 4 commits into
base: f24
Choose a base branch
from

Conversation

Abdallah-Abdaljalil
Copy link

@Abdallah-Abdaljalil Abdallah-Abdaljalil commented Aug 30, 2024

Refactored the code in settings.js to reduce the complexity from 16.

Changes

Created a function getValue to perform the loop needed to traverse the objects. It reduces the amount of conditionals and nested loops or conditions. A ternary operator is also used for def which reduces conditionals. Moving the logic of looping through the object given in a helper function makes the code more efficient and readable, which should ultimately reduce complexity.

Resolving Issue #4

@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10687904534

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10550029021: -0.005%
Covered Lines: 22320
Relevant Lines: 25580

💛 - Coveralls

Copy link

sonarcloud bot commented Sep 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants