Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code in settings.js to reduce the complexity from 16.
Changes
Created a function
getValue
to perform the loop needed to traverse the objects. It reduces the amount of conditionals and nested loops or conditions. A ternary operator is also used fordef
which reduces conditionals. Moving the logic of looping through the object given in a helper function makes the code more efficient and readable, which should ultimately reduce complexity.Resolving Issue #4