Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored code in src/topics/posts.js #56

Open
wants to merge 7 commits into
base: f24
Choose a base branch
from
Open

Refactored code in src/topics/posts.js #56

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
316fd02
refactoring: helper function for addEventStartEnd
njouud Sep 2, 2024
a47eb5a
added a comment, retry sonarcloud
njouud Sep 3, 2024
3f5ef12
adding one more helper function
njouud Sep 3, 2024
11547d3
extracted nested if statements in handleLastPost helper
njouud Sep 3, 2024
31fec29
added a comment, retrying sonarcloud test
njouud Sep 3, 2024
6903186
added a console.log statement in refactored code to check logs
njouud Sep 5, 2024
b3380d2
commenting out console.log lines
njouud Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 51 additions & 16 deletions src/topics/posts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,30 +76,65 @@ module.exports = function (Topics) {
};

async function addEventStartEnd(postData, set, reverse, topicData) {
// console.log('njoud: refactored code is running');
if (!postData.length) {
return;
}
postData.forEach((p, index) => {
/*
helper function to be called for each post object
in the postData array
to set the start and end times of each post
*/
function setEventTimes(p, nextPost, reverse, topicData) {
// console.log('njoud: refactored code is running (helper function 1)');
if (p && p.index === 0 && reverse) {
p.eventStart = topicData.lastposttime;
p.eventEnd = Date.now();
} else if (p && postData[index + 1]) {
p.eventStart = reverse ? postData[index + 1].timestamp : p.timestamp;
p.eventEnd = reverse ? p.timestamp : postData[index + 1].timestamp;
} else if (p && nextPost) {
p.eventStart = reverse ? nextPost.timestamp : p.timestamp;
p.eventEnd = reverse ? p.timestamp : nextPost.timestamp;
}
}
postData.forEach((p, index) => {
const nextPost = postData[index + 1];
setEventTimes(p, nextPost, reverse, topicData);
});
const lastPost = postData[postData.length - 1];
if (lastPost) {
lastPost.eventStart = reverse ? topicData.timestamp : lastPost.timestamp;
lastPost.eventEnd = reverse ? lastPost.timestamp : Date.now();
if (lastPost.index) {
const nextPost = await db[reverse ? 'getSortedSetRevRangeWithScores' : 'getSortedSetRangeWithScores'](set, lastPost.index, lastPost.index);
if (reverse) {
lastPost.eventStart = nextPost.length ? nextPost[0].score : lastPost.eventStart;
} else {
lastPost.eventEnd = nextPost.length ? nextPost[0].score : lastPost.eventEnd;
}
}
/*
call another helper function to handle the last post
*/
await handleLastPost(postData, set, reverse, topicData);
}
/*
helper function for last post
*/
async function handleLastPost(lastPost, set, reverse, topicData) {
// console.log('njoud: refactored code is running (helper function 2)');
if (!lastPost) {
return;
}
/*
break down if else statements
*/
if (reverse) {
lastPost.eventStart = topicData.timestamp;
lastPost.eventEnd = lastPost.timestamp;
} else {
lastPost.eventStart = lastPost.timestamp;
lastPost.eventEnd = Date.now();
}
if (!lastPost.index) {
return;
}
const getNextPost = reverse ? 'getSortedSetRevRangeWithScores' : 'getSortedSetRangeWithScores';
const nextPost = await db[getNextPost](set, lastPost.index, lastPost.index);
/*
combine reverse and nextPost.length checks
in one boolean check
*/
if (reverse && nextPost.length) {
lastPost.eventStart = nextPost[0].score;
} else if (!reverse && nextPost.length) {
lastPost.eventEnd = nextPost[0].score;
}
}

Expand Down