Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in src/socket.io/admin/rooms.js #63

Open
wants to merge 10 commits into
base: f24
Choose a base branch
from

Conversation

galishaq
Copy link

@galishaq galishaq commented Sep 2, 2024

refactoring code of the function SocketRooms.getAll to reduce its complexity by separating it into helper functions
resolves #49

@coveralls
Copy link

coveralls commented Sep 2, 2024

Pull Request Test Coverage Report for Build 10710666003

Details

  • 26 of 30 (86.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 82.669%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/socket.io/admin/rooms.js 26 30 86.67%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10550029021: -0.002%
Covered Lines: 22330
Relevant Lines: 25590

💛 - Coveralls

Copy link

sonarcloud bot commented Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring code in src/socket.io/admin/rooms.js
2 participants