Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decreased nesting levels in function (src/topics/sorted.js) #82

Open
wants to merge 1 commit into
base: f24
Choose a base branch
from

Conversation

rmmahmou
Copy link

@rmmahmou rmmahmou commented Sep 4, 2024

This pull request resolves #23 as it will decrease the depth of nesting of a 5-level function declaration by extracting some functions out of the containing function.

Changes were tested using the npm run lint and npm run test commands.

Copy link

sonarcloud bot commented Sep 4, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10698927097

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 82.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/sorted.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10550029021: -0.007%
Covered Lines: 22322
Relevant Lines: 25583

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring code in src/topics/sorted.js
2 participants