Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Search Interface to the file: node_modules/nodebb-theme-harmony/templates/category.tpl #28

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

rmmahmou
Copy link

@rmmahmou rmmahmou commented Sep 24, 2024

Added a search box with an icon to enable searching the topics in the current category. The file changed: node_modules/nodebb-theme-harmony/templates/category. The theme was modified. The .gitignore was adjusted to exclude node_modules for changes to be tracked.
*this is my latest pull request, I have made previous pull requests but had to close them because of some errors. Please refer to them for my original commits.
resolves #12

Tested using using website rebuild (manual), team verification (through pulls).

@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11058454439

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.749%

Totals Coverage Status
Change from base Build 11057403369: 0.0%
Covered Lines: 22356
Relevant Lines: 25601

💛 - Coveralls

Copy link

@zanzoonh zanzoonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@zanzoonh zanzoonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Hakaabi Hakaabi self-requested a review September 26, 2024 16:01
Copy link

@Hakaabi Hakaabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! amazing progress front-end wise.

@zanzoonh zanzoonh added this to the Sprint 1 milestone Sep 26, 2024
@rmmahmou rmmahmou closed this Sep 26, 2024
@rmmahmou rmmahmou reopened this Sep 26, 2024
@rmmahmou rmmahmou merged commit 9c21755 into f24 Sep 26, 2024
1 check passed
@rmmahmou rmmahmou changed the title Adding Searchbox to the file: node_modules/nodebb-theme-harmony/templates/category.tpl Adding Searchbox Interface to the file: node_modules/nodebb-theme-harmony/templates/category.tpl Sep 26, 2024
@rmmahmou rmmahmou changed the title Adding Searchbox Interface to the file: node_modules/nodebb-theme-harmony/templates/category.tpl Adding Search Interface to the file: node_modules/nodebb-theme-harmony/templates/category.tpl Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding search button interface to the documents - User Story 1
4 participants