-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts-standard testing #62
base: f24
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 11498964473Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation of the tool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installation looks great!
I added TypeScript linting using ts-standard tool to improve code consistency and quality for '.ts' files in the project.
What I did:
I added ts-standard linting configuration to package.json and then created and updated tsconfig.json and tsconfig.eslint.json for TypeScript project settings. Then, I fixed paths for TypeScript linting to ensure ts-standard correctly detects the tsconfig.json file. I also updated lint-staged config to automatically fix .ts files.
Files I modified/added:
1.package.json:
I added 'lint:ts' script using ts-standard and updated 'lint-staged' to auto-fix .ts files on commit and linked 'tsconfig.json' for TypeScript linting via the ts-standard config
2.tsconfig.json:
I created the file and added a minimal TypeScript configuration to define project structure and linting paths
3.tsconfig.eslint.json:
I added an ESLint-specific TypeScript configuration extending the main tsconfig.json for linting purposes
Screenshot of output:
*note: The branch name reflects the initial tool I was going to install (StandardJs) but later on decided on ts-standard.