Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-standard testing #62

Open
wants to merge 6 commits into
base: f24
Choose a base branch
from
Open

ts-standard testing #62

wants to merge 6 commits into from

Conversation

Hakaabi
Copy link

@Hakaabi Hakaabi commented Oct 24, 2024

I added TypeScript linting using ts-standard tool to improve code consistency and quality for '.ts' files in the project.

What I did:
I added ts-standard linting configuration to package.json and then created and updated tsconfig.json and tsconfig.eslint.json for TypeScript project settings. Then, I fixed paths for TypeScript linting to ensure ts-standard correctly detects the tsconfig.json file. I also updated lint-staged config to automatically fix .ts files.

Files I modified/added:
1.package.json:
I added 'lint:ts' script using ts-standard and updated 'lint-staged' to auto-fix .ts files on commit and linked 'tsconfig.json' for TypeScript linting via the ts-standard config

2.tsconfig.json:
I created the file and added a minimal TypeScript configuration to define project structure and linting paths

3.tsconfig.eslint.json:
I added an ESLint-specific TypeScript configuration extending the main tsconfig.json for linting purposes

Screenshot of output:
Screenshot 2024-10-24 at 15 07 09
Screenshot 2024-10-24 at 15 07 14

*note: The branch name reflects the initial tool I was going to install (StandardJs) but later on decided on ts-standard.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11498964473

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.586%

Totals Coverage Status
Change from base Build 11495456179: 0.005%
Covered Lines: 22388
Relevant Lines: 25677

💛 - Coveralls

@Hakaabi Hakaabi self-assigned this Oct 24, 2024
@rmmahmou rmmahmou self-requested a review October 27, 2024 14:27
Copy link

@rmmahmou rmmahmou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation of the tool!

@Hakaabi Hakaabi changed the title Standardjs testing ts-standard testing Oct 27, 2024
@rmmahmou rmmahmou self-requested a review October 27, 2024 19:47
Copy link

@rmmahmou rmmahmou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@AlAnoud2003 AlAnoud2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants