Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code in src/user/uploads.js #29

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

akobaidan
Copy link

Changed the function based on the SonarCloud warning to not nest functions more than 4 levels deep.

Copy link

@aattiyah aattiyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. The implementation is clean and passes all the tests.

Copy link
Member

@mohamed-elzeni mohamed-elzeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactored code looks good to me. But can we remove the added dump.rdb? I believe it's some sort of a log file for the Redis server and shouldn't be part of the codebase.

Copy link
Member

@mohamed-elzeni mohamed-elzeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aattiyah aattiyah merged commit 7fd8045 into f24 Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants