-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added front end button to submit anonymously (User Story 4) #30
Conversation
Pull Request Test Coverage Report for Build 11012250000Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
changes are showing now after updating git ignore! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button is added in node_modules/nodebb-plugin-composer-default/static/templates/partials/composer-title-container.tpl. Follows the style of other code and is clear and cleanly written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we can remove dump.rdb after we merge all changes for this sprint.
Okay glad that it's good. I accidentally clicked merged before the approvals but its good that there are no edits needed to be made. |
This pull request adds a "Post Anonymously" option to the composer submit dropdown, allowing users to submit their posts anonymously. The option is added as a new list item within the submitOptions dropdown in the composer action bar. The file that has been modified is nodeBB/nodebb-plugin-composer-default/static/templates/partials/composer-title-container.tpl. This resolves #9.