Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added front end button to submit anonymously (User Story 4) #30

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

tatougueye
Copy link

@tatougueye tatougueye commented Sep 21, 2024

This pull request adds a "Post Anonymously" option to the composer submit dropdown, allowing users to submit their posts anonymously. The option is added as a new list item within the submitOptions dropdown in the composer action bar. The file that has been modified is nodeBB/nodebb-plugin-composer-default/static/templates/partials/composer-title-container.tpl. This resolves #9.

@coveralls
Copy link

coveralls commented Sep 21, 2024

Pull Request Test Coverage Report for Build 11012250000

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 82.674%

Files with Coverage Reduction New Missed Lines %
src/user/uploads.js 5 86.15%
Totals Coverage Status
Change from base Build 10939907093: 0.002%
Covered Lines: 22341
Relevant Lines: 25604

💛 - Coveralls

@aattiyah aattiyah added this to the Sprint 1 milestone Sep 23, 2024
@aattiyah aattiyah changed the title added front end button to submit anonymously added front end button to submit anonymously (User Story 4) Sep 23, 2024
@aattiyah aattiyah added the frontend main code is written in frontend label Sep 23, 2024
@tatougueye
Copy link
Author

changes are showing now after updating git ignore!

@tatougueye tatougueye merged commit b8f299f into f24 Sep 24, 2024
1 check passed
Copy link

@aattiyah aattiyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button is added in node_modules/nodebb-plugin-composer-default/static/templates/partials/composer-title-container.tpl. Follows the style of other code and is clear and cleanly written.

Copy link
Member

@mohamed-elzeni mohamed-elzeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can remove dump.rdb after we merge all changes for this sprint.

@tatougueye
Copy link
Author

Okay glad that it's good. I accidentally clicked merged before the approvals but its good that there are no edits needed to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment