-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend logic for posting anonymously (User Story 4) #37
Conversation
Pull Request Test Coverage Report for Build 11057018853Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I pulled it and its incorporating well with the changes I made!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds the backend logic of posting anonymously.
It is done by capturing the click of the added "Submit Anonymously" button in the submit dropdown menu and adding an attribute that is passed to the post function. The post function then utilizes
Topics.post
to post as a guest by changing the user ID to 0, making the author of the post completely anonymous.This has been tested by the linting and testing suite, in addition to testing the interface manually.
The main changes are in the following files:
node_modules/nodebb-plugin-composer-default/static/lib/composer.js
node_modules/nodebb-plugin-composer-default/static/templates/partials/composer-title-container.tpl
src/topics/create.js
This resolves #10 & resolves #11. This also fully completes and resolves #15.