Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking approved status of post in src/posts/create.js #35

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

dmohanadi
Copy link

@dmohanadi dmohanadi commented Sep 23, 2024

File: src/posts/create.js

Changes made:
-Updated database schema by creating the isApproved variable and setting it initially to false (Boolean)
(Instructors can then set it to true if they approve of it)
-Added isApproved variable to the postData object/dictionary to attach the variable to the post and check the status of a post if its instructor approved.
Issue Resolvement: Making the isApproved variable into a boolean directly created the issue that the variable isn't defined in the schema, therefore the variable was made into a string version of true or false -> const { isApproved } = data

Solves Task #14

…g it to postData object in the create file to track if a post is instructor approved
@Tasnim1147 Tasnim1147 marked this pull request as draft September 24, 2024 11:07
@Tasnim1147
Copy link

It is a good practise to keep the PR in draft mode if its not ready.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11022261615

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 82.66%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10973966126: 0.005%
Covered Lines: 22331
Relevant Lines: 25595

💛 - Coveralls

@dmohanadi dmohanadi marked this pull request as ready for review September 26, 2024 19:07
@jdufitum jdufitum added this to the Sprint 1 milestone Sep 26, 2024
@jdufitum jdufitum assigned dmohanadi and Tasnim1147 and unassigned dmohanadi Sep 26, 2024
@jdufitum jdufitum merged commit bb14846 into CMU-17313Q:f24 Sep 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants