Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static tool: JSHint #78

Open
wants to merge 2 commits into
base: f24
Choose a base branch
from
Open

Added static tool: JSHint #78

wants to merge 2 commits into from

Conversation

rkensouh
Copy link

@rkensouh rkensouh commented Oct 23, 2024

Through the terminal, I initialized and set up JSHint through the command npm install -g jshint. I then ran the command npm install jshint --save-dev. It was then added to the dev dependencies in the package.json file.

In addition, I created the file .jshintrc and added it in the root of the application which is a file that contains rules and definitions that JSHint will use to analyze JavaScript code.

In addition, I added a .jshintignore file in the root directory of the project to ignores files that might cause infinite loops and problems when JSHint runs because it might not be compatible with JSHint.

At first when I ran npm run lint-jshint in it threw some errors because my .jshintrc was not compatible with our program but I edited it to be compatible and now when you run the command it passes with no errors.
Screen Shot 2024-10-23 at 9 47 35 PM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11482405960

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.367%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11459547874: -0.005%
Covered Lines: 22368
Relevant Lines: 25711

💛 - Coveralls

@rkensouh rkensouh changed the title Js hint testing Added static tool: JSHint Oct 25, 2024
@rkensouh rkensouh requested a review from njouud October 25, 2024 09:15
Copy link

@njouud njouud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants