Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji Reaction Backend and Frontend Changes #24

Open
wants to merge 24 commits into
base: f24
Choose a base branch
from

Conversation

T7alabdullah
Copy link

@T7alabdullah T7alabdullah commented Sep 26, 2024

This pull request features changes made to the topic.tpl file under node_modules to display the front end changes of the emoji reaction button when replying to the post, as well as changes to the [src/routes/reactions.js] file to include the logic that to fetch and display emoji reaction counts when clicked on. Both changes have been worked on by both Talal and Filippos together.

Solves issue #10 and #11

fdounis and others added 24 commits September 22, 2024 22:45
Copy link

@mthani2 mthani2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good progress but it looks like there are some backend issues that are causing conflicts:
Screenshot 2024-09-26 at 5 34 41 PM

For now, let's avoid merging.

@T7alabdullah T7alabdullah linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

@Nalseaf Nalseaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mthani2
Copy link

mthani2 commented Oct 10, 2024

This branch and pull request also completes the necessary database changes for this user story.
Closing #12

@T7alabdullah T7alabdullah linked an issue Oct 10, 2024 that may be closed by this pull request
@fdounis
Copy link

fdounis commented Oct 20, 2024

Just looking back at the old iteration of the emoji feature. Was good progress, but still need to figure out the back-end part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants