Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend solved feature #29

Open
wants to merge 9 commits into
base: f24
Choose a base branch
from
Open

Backend solved feature #29

wants to merge 9 commits into from

Conversation

T7alabdullah
Copy link

@T7alabdullah T7alabdullah commented Oct 10, 2024

Implemented the backend logic for the "Mark As Solved" feature. The main functionality includes creating server-side API routes that allow posts to be marked as solved or unsolved, effectively integrating this feature with the NodeBB forum system. The logic includes handling state changes, updating the database accordingly, and ensuring that the frontend can trigger these backend processes seamlessly. Routing issues has caused the feature to not fully be completed. CURL POST commands specifically failed to identify the correct routes, likely due to minor syntax errors or overlooked details.

Next steps would be as follows:
Debug Routing Issues: Review the server-side API route definitions to identify any syntax errors or inconsistencies with NodeBB’s routing structure.
Log Requests: Implement detailed logging for incoming CURL POST requests to track where the route resolution is failing.
Collaborate for Code Review: Request a team member to review the backend logic for a fresh perspective to catch any overlooked details.

Copy link

@mthani2 mthani2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many indentation errors that need to be resolved, this cannot be merged until the actions pass all the checks.

Copy link

@sarrakhelifi-cmu sarrakhelifi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of the "Mark As Solved" feature seems to be well-executed, just further investigation into the routing logic and adding more tests to ensure smooth integration with the frontend and backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working Working Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Story 2: Define who has the ability to mark a question as "solved" (original poster)
3 participants