-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji Reaction Full Feature Implementation #30
base: f24
Are you sure you want to change the base?
Conversation
…dy implemented before, but refined)
…e page loads to the topic.tpl file
…reaction instead of /post/3/reaction when button is clicked
…n.json file inside
…folder, with the server-side logic for handling reactions
…nd keep emoji count
… folder to start testing on the backend
…est/back-end directory. This file will house all tests related to the emoji reactions API endpoints.
…ccessfully added to a post. This ensures that the POST /api/post/:postId/reaction endpoint functions correctly under normal conditions
…actions. Attempting to add a reaction that is not among the predefined valid emojis (👍, ❤️, 😂) should result in a 400 Bad Request response with an appropriate error message.
…actions. The API should respond with a 403 Forbidden status and an appropriate error message when a user who is not logged in attempts to add a reaction.
… errors during reaction addition. Simulate a database error and verify that the API responds with a 500 Internal Server Error and an appropriate error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files seem to be correct, it could perhaps be a simple syntax or formatting issue that is causing the routing issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress on this looks great! the dum.rb conflict shouldn't be too hard to resolve but the routing issue still needs work it seems.
Overview
The Emoji Reaction feature enhances user interaction within our NodeBB forum by allowing users to express their sentiments through emojis on posts. This functionality aims to foster a more engaging and expressive community environment. As part of this pull request, we:
Implemented Changes
Front-End Enhancements:
Revamped Design Placement: The emoji reaction buttons have been repositioned to a more accessible and intuitive location beneath each post. Previously, the three reaction buttons were scattered in arbitrary locations, which hindered user accessibility.
Styling Consistency: The buttons' styling has been overhauled to align seamlessly with the forum's overall design aesthetic. This includes color schemes, sizing, and hover effects to ensure a cohesive look and feel across the platform.
Back-End Development Attempts:
Route Configuration: Multiple attempts were made to establish custom routes to handle emoji reactions. This included creating dedicated JavaScript files and integrating custom routes within the NodeBB framework.
Plugin Development: A bespoke plugin was developed to manage the backend logic of emoji reactions. This plugin was then installed via the NodeBB administrative dashboard to facilitate seamless integration with the existing system.
Comprehensive Testing Suite:
Back-End Integration Issues:
Resource Constraints: Initially, both Talal and Filippos collaborated on the front-end components. However, resource reallocation occurred when Talal transitioned to focus on the "Marked as Solved" feature, leaving the back-end development of the emoji reactions solely to Filippos. This shift introduced delays and limited collaborative troubleshooting opportunities.
Underestimation of Complexity: The time required to locate and modify the correct files for both front-end and back-end implementations was significantly underestimated. The initial week was largely consumed by file discovery and setup, which impacted the subsequent development timeline.
Inability to Verify Tests: Due to the unresolved API routing issues, the back-end tests, while thoroughly written, could not be executed effectively. This gap prevented us from validating the robustness and reliability of the emoji reaction functionality through our test suites.
Current Status
Next Steps
Resolve API Routing Conflicts:
Expand Test Coverage: Develop additional tests to cover edge cases and ensure the feature's robustness under various scenarios.
Connects to #11, #12 and #13.