Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dREL evaluation method of the ATOM_TYPE category #451

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

vaitkus
Copy link
Collaborator

@vaitkus vaitkus commented Jul 13, 2023

The values of _atom_site.type_symbol should be used first when determining the values of _atom_type.symbol since the assigned types might differ from those derived from atom labels.
Since the dREL method for _atom_site.type_symbol data item also derives the values from the values of _atom_site.label, the updated dREL will still yield the same result in cases when the values of _atom_site.type_symbol are not explicitly defined.

@vaitkus
Copy link
Collaborator Author

vaitkus commented Jul 13, 2023

Also, I just realised that there might be a need to redesignate the entire method from 'Evaluation' to 'Definition' as the type symbol derived from the atom label is not required to be exact (see issue #452).
This would apply to both the updated code and the old variant.

@jamesrhester jamesrhester merged commit 02b65fa into COMCIFS:master Jul 14, 2023
@jamesrhester
Copy link
Contributor

I don't think this method needs to change to Definition, but the ATOM_SITE method should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants