-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting of values in Ranges #19
Comments
This is really more appropriate for the style guide so I've transferred the issue. |
I agree that writing reals with at least one digit after the decimal point is more harmonious. In terms of the style guide, the stipulation would be that there should be at least one digit after the decimal point, and any following digits must be non-zero if present. |
rowlesmr
added a commit
to rowlesmr/cif_core
that referenced
this issue
Jun 25, 2023
to follow guidance in COMCIFS/comcifs.github.io#19
This was referenced Jun 25, 2023
jamesrhester
pushed a commit
to COMCIFS/cif_core
that referenced
this issue
Jun 28, 2023
Format enumeration ranges to follow guidance in COMCIFS/comcifs.github.io#19 --------- Co-authored-by: vaitkus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are different ways of formatting values in ranges:
IIRC, CIF2 specification separated the formatting of a value from it's interpretation as an integer/real, so this is purely cosmetic, but...
For consistency, should there be a standard way of doing things?
Reals -> 1.0
Integers -> 1
??
The text was updated successfully, but these errors were encountered: