Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework design table and L1 column structure #124

Merged
merged 13 commits into from
Apr 4, 2024
Merged

Rework design table and L1 column structure #124

merged 13 commits into from
Apr 4, 2024

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Apr 2, 2024

Our initial L1 data (v0-9) had a lot of information shoehorned into the "design_link" column. This column was a pain for users to parse; difficult to work with or update for us; and made it hard to spot mistakes.

This PR changes the design table structure so that individual columns encode information about

  • Instrument - the overall measurement instrument (e.g., "AquaTROLL")
  • Which - which specific AquaTROLL, etc.,
  • Individual - either which experiment unit (e.g. tree) is being measured, or which named TEROS sensor, etc.
  • research_name - as before, this describes the value column, i.e. what is being measured

In summary, this makes working with the design table easier for us, and working with the L1 data easier for everyone.

Old L1 data structure

Screenshot 2024-04-02 at 9 38 51 AM

New structure (this PR)

Screenshot 2024-04-02 at 9 40 23 AM

@bpbond bpbond requested a review from stephpenn1 April 2, 2024 13:46
@bpbond bpbond mentioned this pull request Apr 2, 2024
13 tasks
@bpbond
Copy link
Member Author

bpbond commented Apr 2, 2024

When you get to this SP-

This is our last chance to change the L1 structure without breaking things--that is, when we declare it "v1-0", people will assume and expect that it's stable for a while.

With that in mind, we might want to consider changing some of the column names above:

  • research_name - what about "Variable"?
  • Instrument - any better ideas?
  • Which - any better ideas?
  • Individual - ?
  • value - to "Value" (for consistent capitalization)?

Thx

@stephpenn1
Copy link
Member

Okay - I'm running this on my computer so I can inspect each part and will give full feedback after

@bpbond
Copy link
Member Author

bpbond commented Apr 4, 2024

@stephpenn1 Is it OK if we merge this and then deal with reworking columns ( #127 ) via a second PR? If you approve, that would be helpful, as I have some other changes that depend on this. Thanks

Copy link
Member

@stephpenn1 stephpenn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will revisit the new columns, approving this for now for merging

@bpbond bpbond merged commit f6be773 into main Apr 4, 2024
1 check passed
@bpbond bpbond deleted the rework_dt branch April 4, 2024 16:59
@bpbond
Copy link
Member Author

bpbond commented Apr 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery versus solar voltages MSM Buoy ExoTable not appearing in L1_normalize outputs?
2 participants